Use random name for temp table

Author: spicychickensauce

lib/ecto/adapters/sqlite3/connection.ex

@@ -1557,17 +1557,18 @@ defmodule Ecto.Adapters.SQLite3.Connection do
   defp values_list(types, idx, num_rows) do
     rows = :lists.seq(1, num_rows, 1)
     col_names = Enum.map_join(types, ", ", &elem(&1, 0))
+    table_name = "temp_#{:rand.uniform(100_000)}"
 
     [
-      "WITH xxx(",
+      "WITH #{table_name}(",
       col_names,
       ") AS (VALUES ",
       intersperse_reduce(rows, ?,, idx, fn _, idx ->
         {value, idx} = values_expr(types, idx)
         {[?(, value, ?)], idx}
       end)
       |> elem(0),
-      ") SELECT * FROM xxx"
+      ") SELECT * FROM #{table_name}"
     ]
   end
 

test/ecto/adapters/sqlite3/connection/join_test.exs

@@ -139,6 +139,9 @@ defmodule Ecto.Adapters.SQLite3.Connection.JoinTest do
     rows = [%{x: 1, y: 1}, %{x: 2, y: 2}]
     types = %{x: :integer, y: :integer}
 
+    # Seeding rand ensures we get temp_78027 as the CTE name
+    :rand.seed(:exsss, {1, 2, 3})
+
     query =
       Schema
       |> join(
@@ -151,7 +154,7 @@ defmodule Ecto.Adapters.SQLite3.Connection.JoinTest do
       |> plan()
 
     assert ~s{SELECT s0."id", v1."x" FROM "schema" AS s0 } <>
-             ~s{INNER JOIN (WITH xxx(y, x) AS (VALUES ($1,$2),($3,$4)) SELECT * FROM xxx) AS v1 } <>
+             ~s{INNER JOIN (WITH temp_78027(y, x) AS (VALUES ($1,$2),($3,$4)) SELECT * FROM temp_78027) AS v1 } <>
              ~s{ON (v1."x" = s0."x") AND (v1."y" = s0."y")} ==
              all(query)
   end