Skip to content

Commit c78261e

Browse files
authored
Symbol - Module mismatch (#54)
* recreate error condition * reduce extra inspections * initial module seeding functional * organize calls * tweak ci for multiple examples * refactory around built-in props instead of descriptor+guess * fix nested_types behavior * update extensions to remove module guessing * clean up package generation * linting * cleanup * regenerate protos and add custom name proto * add simple test over custom prefix service * patch unrapping service descriptors * try to cover FileDescriptor unwrapping * cleanup * remove double-line in examples v2 generate_protos * walk back example tools change, generate breaks * clean and re-test example protos generate * cleanup README * bump minor version for refactor and new prefix support * add changelog
1 parent 38f9fd6 commit c78261e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+1491
-318
lines changed

.formatter.exs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
[
44
"{mix,.formatter,.credo}.exs",
55
"{config,lib,priv,test}/**/*.{ex,exs}",
6-
"examples/helloworld/{config,lib,priv,test}/**/*.{ex,exs}"
6+
"examples/helloworld_v2/{config,lib,priv,test}/**/*.{ex,exs}",
7+
"examples/helloworld_v3/{config,lib,priv,test}/**/*.{ex,exs}"
78
]
89
|> Enum.flat_map(&Path.wildcard(&1, match_dot: true))
910
|> Enum.reject(&String.match?(&1, ~r/^.*\.pb\.ex$/))

.github/workflows/ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,9 @@ jobs:
164164

165165
check_example:
166166
name: Run example helloworld tests
167+
strategy:
168+
matrix:
169+
path: [./examples/helloworld_v2, ./examples/helloworld_v3]
167170
runs-on: ubuntu-latest
168171
steps:
169172
- uses: actions/checkout@v4
@@ -176,7 +179,7 @@ jobs:
176179
elixir-version: 1.18.x
177180

178181
- name: Build and Test
179-
working-directory: ./examples/helloworld
182+
working-directory: ${{ matrix.path }}
180183
run: |
181184
mix deps.get
182185
mix test

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# CHANGELOG
2+
3+
## v0.2.0 (2025-06-18)
4+
5+
### Bug fixes
6+
7+
- https://github.com/elixir-grpc/grpc-reflection/issues/53
8+
9+
### Enhancements
10+
11+
- Reflection tree builder refactored to match grpc symbols against GRPC-exposed module names

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ Here are some example `grpcurl` commands and responses excersizing the reflectio
6363

6464
```shell
6565
$ grpcurl -v -plaintext 127.0.0.1:50051 list
66-
grpc.reflection.v1.ServerReflection
6766
helloworld.Greeter
6867

6968
$ grpcurl -v -plaintext 127.0.0.1:50051 list helloworld.Greeter

examples/helloworld/mix.lock

Lines changed: 0 additions & 13 deletions
This file was deleted.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)