Skip to content

Fix action buttons #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jaimeiniesta opened this issue Mar 28, 2025 · 3 comments · May be fixed by #146
Open

Fix action buttons #145

jaimeiniesta opened this issue Mar 28, 2025 · 3 comments · May be fixed by #146
Assignees
@jaimeiniesta
Labels
enhancement New feature or request

Comments

@jaimeiniesta
Copy link

Hi, I was trying the new mute action and it caught my attention that, while the Resolve / Unresolve action is a button, the new Mute / Unmute action is a link. Both should be buttons, as they trigger actions, aren't used for navigation.

Making both actions as button provides a unified experience when using the keyboard, as buttons can be triggered using the space and return keys, whereas links can't be triggered with the space key.

I'm working on a PR that also fixes the Unmute action as it's currently broken in two lines.

Image

Here's my work in progress, as soon as I fix the responsive design for it I'll send a PR if that's OK.

Grabacion.de.pantalla.2025-03-28.a.las.15.32.00.mov
@jaimeiniesta jaimeiniesta linked a pull request Mar 28, 2025 that will close this issue
Draft
@odarriba
Copy link
Contributor

PRs are more than welcome! Thanks @jaimeiniesta

@odarriba odarriba added the enhancement New feature or request label Mar 31, 2025
@jaimeiniesta
Copy link
Author

My pleasure!

I'm working on it but changing the design is a bit slow as there's no live reload. Am I missing something in the dev setup? I have to restart the server after every change...

@crbelaus
Copy link
Contributor

crbelaus commented Apr 1, 2025

My pleasure!

I'm working on it but changing the design is a bit slow as there's no live reload. Am I missing something in the dev setup? I have to restart the server after every change...

You are not missing anything @jaimeiniesta. I've opened an issue in the Phoenix Playground repository a couple days ago about this same issue phoenix-playground/phoenix_playground#24

Unfortunately I didn't have time to take a look at the LiveScript project yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaimeiniesta jaimeiniesta

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Fix action buttons jaimeiniesta/error-tracker
3 participants
@jaimeiniesta @odarriba @crbelaus