Skip to content

Commit e699125

Browse files
Merge pull request #86 from petergoldstein/feature/update_to_rails_4_+
Version 2.0.0 / Rails 4+ changes
2 parents 1d98549 + 1947931 commit e699125

13 files changed

+157
-437
lines changed

.travis.yml

-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
gemfile:
2-
- gemfiles/Gemfile.rails-3.0
3-
- gemfiles/Gemfile.rails-3.1
4-
- gemfiles/Gemfile.rails-3.2
52
- gemfiles/Gemfile.rails-4.0
63
- gemfiles/Gemfile.rails-4.1
74
rvm:

CHANGELOG

-22
This file was deleted.

CHANGELOG.md

+62
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
v2.0.0
2+
------
3+
4+
- Removed support for Rails 3.x - gem only supports Rails 4+ going forward.
5+
- Updated rspec versions to 3.x and switch to 'expect' syntax.
6+
- Removed default values from referencing id columns in `Comment` class.
7+
- Added missing '.rb' suffix on migration files.
8+
9+
v1.2.0
10+
------
11+
12+
- Updated rspec versions to 2.x and make corresponding changes to Rakefile.
13+
- Removed sqlite3 development dependency to support JRuby in development/test.
14+
- Added initial Rails 4 support, subject to acts_as_nested_set dependency.
15+
- Removed empty string default values for string columns in `Comment`.
16+
17+
v1.1.3
18+
------
19+
20+
- Fixed typos in acts_as_votable integration comment and instructions.
21+
- Updated commentable to call `destroy_all` on `root_comments`, rather than on all comments (to ensure comments are properly deleted).
22+
- Fixed polymorphic index to include `commentable_type`.
23+
- Update Comment to use `validates` rather than the deprecated `validates_presence_of`.
24+
25+
v1.1.2
26+
------
27+
28+
- Updated awesome_nested_set dependency to account for change in repository location.
29+
- Fixed Comment so it stores the correct class when a commentable is an STL child class.
30+
- Added commentable association to Comment.
31+
- Assorted README changes.
32+
33+
v1.1.1
34+
------
35+
36+
- Removed length limit on Commentable class name.
37+
- Removed default order from `comment_threads`
38+
39+
v1.1.0
40+
------
41+
42+
- Updated to Rails 3+.
43+
- First Rubygems release.
44+
45+
v0.1.2
46+
------
47+
48+
- Added new documentation in README that should better help users understand this plugin.
49+
- Added new instance method `root_comments` that will return all comments belonging to a model except child comments.
50+
- Added new class method for Comment: `self.build_from(object, user_id, comment_text:string)`. This method cleans up the code inside the controllers.
51+
- Added new class method for Comment: `has_children?` that will return true or false depending on if a comment has children.
52+
- Updated deprecated code in instance method `comments_ordered_by_submitted` - changed `self.type.name` to `self.class.name`.
53+
54+
v0.1.1
55+
------
56+
57+
- Fixes to gemspec.
58+
59+
v0.1.0
60+
------
61+
62+
- Initial Release.

Gemfile

+2-14
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,8 @@
1-
# Generated from /Users/light/work/my/acts_as_commentable_with_threading/acts_as_commentable_with_threading.gemspec
2-
source 'http://rubygems.org'
1+
source 'https://rubygems.org'
32

4-
gem "activerecord", "~> 4.0"
5-
gem "activesupport", "~> 4.0"
6-
gem "awesome_nested_set", "~> 3.0.0.rc.2"
7-
8-
platforms :rbx do
9-
gem 'rubysl', '~> 2.0'
10-
gem 'rubinius-developer_tools'
11-
end
3+
gemspec
124

135
group :development do
14-
gem "rake", ">= 0"
15-
gem "bundler"
16-
gem "rspec"
176
gem 'activerecord-jdbcsqlite3-adapter', :platforms => :jruby
187
gem 'sqlite3', :platforms => :ruby
19-
gem "rails", "~> 4.0"
208
end

0 commit comments

Comments
 (0)