Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"user-trash-full-symbolic" is identical to normal symbolic trash icon #1158

Open
newhoa opened this issue Dec 17, 2022 · 5 comments
Open

"user-trash-full-symbolic" is identical to normal symbolic trash icon #1158

newhoa opened this issue Dec 17, 2022 · 5 comments

Comments

@newhoa
Copy link
Collaborator

newhoa commented Dec 17, 2022

What Happened?

user-trash-full-symbolic is identical to user-trash-symbolic. user-trash-full-symbolic is also in the status folder while all other trash icons are in the places folder.

Steps to Reproduce

status/symbolic/user-trash-full-symbolic.svg: trash-full

places/symbolic/user-trash-symbolic.svg: trash

Expected Behavior

Full trash should look full or look somehow different. Maybe it could be without lid and have trash (what the fullcolor icon looks like), or look pushed out. Maybe it could use the error or warning class to give it color (I'm not so into this one)?

As for location, according to freedesktop.org, status is the correct location for user-trash-full. Personally I think places makes more sense and is easier to find and keeping them together makes more sense. But if following the fd.org spec is that important then they belong in status.

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@newhoa newhoa changed the title "user-trash-full-symbolic" is identical to normal trash icon "user-trash-full-symbolic" is identical to normal symbolic trash icon Dec 17, 2022
@newhoa
Copy link
Collaborator Author

newhoa commented Dec 17, 2022

Just some quick simple tests of changing the color (error/warning class), or making it look fuller/fatter:

trash-full-sym-test1

Adding an emblem:

trash-full-sym-alert

Current for reference:

trash-full-sym-current

@waldyrious
Copy link
Contributor

Looking at this version:

image

...out of curiosity, was it intentional to make the ridges have more curvature than the sides of the trash can? Realistically, the opposite would be true. Did you perhaps want to make them look like parenthesis? (That's what they look like to me 😅)

As for location, according to freedesktop.org, status is the correct location for user-trash-full.

I don't know how freedesktop.org decisions are made, but couldn't a suggestion be made proposing a change of location for this icon in a later version of the spec?

@frachmadin
Copy link

Maybe something like this, to match with non-symbolic icon.

image

@newhoa
Copy link
Collaborator Author

newhoa commented Dec 19, 2022

@waldyrious Lol "parenthesis garbage can" was my least favorite. Adwaita has a similar design to that so thought I'd try it out. They were just quick rough ideas. As for freedesktop.org I don't know how to suggest changes but according to the site it hasn't been updated since 2006 so I don't think any requests like that would happen any time soon or be priority. (I'd really like to see some new names added)

@frachmadin That is the icon elementary-xfce uses (not sure if it originated there though). I'm not a huge fan of it, the lid on the side looks a little globby and to me it's hard to make out as a garbage can. But you're right it is closer to the non-symbolic version and better than the current.

@waldyrious
Copy link
Contributor

Lol "parenthesis garbage can" was my least favorite. Adwaita has a similar design to that so thought I'd try it out. They were just quick rough ideas.

Well, I do think the idea has merit, and in particular I think curved ridges would work better than the straight ones in trash can icon with bulging sides and straight vertical ridges; but the curvature would have to be adjusted to be more realistic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants