Skip to content

Commit 0d6a3ac

Browse files
authored
Replace Gtk.show_uri with Gtk.UriLauncher (#111)
1 parent 51ba9cf commit 0d6a3ac

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ GitHub Issue Reporter
88
## Building, Testing, and Installation
99

1010
You'll need the following dependencies:
11-
* libappstream-dev
12-
* libgranite-7-dev
13-
* libgtk-4-dev
14-
* libadwaita-1-dev
11+
* libappstream-dev (>=0.12.10)
12+
* libgranite-7-dev (>=7.0.0)
13+
* libgtk-4-dev (>=4.10)
14+
* libadwaita-1-dev (>=1.0.0)
1515
* meson
1616
* valac
1717

meson.build

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ executable(
4040
dependency('glib-2.0'),
4141
dependency('gobject-2.0'),
4242
dependency('granite-7', version: '>=7.0.0'),
43-
dependency('gtk4'),
43+
dependency('gtk4', version: '>= 4.10'),
4444
dependency('libadwaita-1', version: '>=1.0.0')
4545
],
4646
install : true

src/MainWindow.vala

+10-2
Original file line numberDiff line numberDiff line change
@@ -356,8 +356,16 @@ public class Feedback.MainWindow : Gtk.ApplicationWindow {
356356
}
357357

358358
private void launch_from_row (RepoRow row) {
359-
Gtk.show_uri (null, row.url, Gdk.CURRENT_TIME);
360-
close ();
359+
var uri_launcher = new Gtk.UriLauncher (row.url);
360+
uri_launcher.launch.begin (null, null, (obj, res) => {
361+
try {
362+
uri_launcher.launch.end (res);
363+
} catch (Error err) {
364+
warning ("Failed to launch \"%s\": %s", row.url, err.message);
365+
}
366+
367+
close ();
368+
});
361369
}
362370

363371
private async GenericArray<AppStream.Component> get_compulsory_for_desktop (AppStream.Pool appstream_pool) {

0 commit comments

Comments
 (0)