Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style - Clarification needed for whitespace after closing bracket guidelines #204

Open
colinkiama opened this issue Jan 20, 2024 · 0 comments

Comments

@colinkiama
Copy link
Member

colinkiama commented Jan 20, 2024

In the Whitespace section, it's unclear what should happen if a series of lines end with a closing bracket and semi-colon.

For example:

var open_in_terminal_pane_item = new Gtk.MenuItem () {
    action_name = MainWindow.ACTION_PREFIX + MainWindow.ACTION_OPEN_IN_TERMINAL,
    action_target = new Variant.string (file.file.get_path ())
};

and:

var open_in_terminal_pane_label = new Granite.AccelLabel.from_action_name (
    _("Open in Terminal Pane"),
     MainWindow.ACTION_PREFIX + MainWindow.ACTION_OPEN_IN_TERMINAL + "::"
);

Should a blank line get added after the semi-colon (;) in the examples above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant