Supply network configs in default-settings instead of ISO

[ryonakano]

Problem

From elementary/os#745 (comment)

We're supplying the follolwing network configs that prefers NetworkManager instead of netplan for network management in the OS repository:

• https://github.com/elementary/os/blob/805f44d164c511034edd515c455fafeae280b6d2/etc/config/includes.chroot/etc/netplan/01-network-manager-all.yml
• https://github.com/elementary/os/blob/805f44d164c511034edd515c455fafeae280b6d2/etc/config/includes.chroot/etc/NetworkManager/conf.d/10-globally-managed-devices.conf

This works, but it won't be supplied as an system update and requires a build of ISO when we update these files.

Proposal

• Check the behavior for how the package installs for someone that's already manually created that file (see Prevent override 10-globally-managed-devices.conf overwritten by package update os#745 (comment))
• Import the above two files in default-settings → Import network configurations from the os repository #325
• Remove the above two files from os → Remove network configurations os#748

Prior Art (Optional)

No response

[ryonakano]

Would need to check the behaviour for how the package installs for someone that's already manually created that file.

(From elementary/os#745 (comment))

@davidmhewitt @danirabbit It looks like it's fine even if the manually created conf file exists.

I try installing the generated deb file with debuild -us -uc command and see the apt command don't warns or errors whether there are manually created file or not:

Manually Created 10-globally-managed-devices.conf

user@test-vm:~/work/default-settings$ cat /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
user@test-vm:~/work/default-settings$ ls -l /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
-rw-r--r-- 1 root root 0 Jan  5 08:26 /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
user@test-vm:~/work/default-settings$ cat /etc/netplan/01-network-manager-all.yml
# Let NetworkManager manage all devices on this system
network:
  version: 2
  renderer: NetworkManager
user@test-vm:~/work/default-settings$ ls -l /etc/netplan/01-network-manager-all.yml
-rw-r--r-- 1 root root 104 Nov 22 01:58 /etc/netplan/01-network-manager-all.yml
user@test-vm:~/work/default-settings$ sudo apt install ../elementary-default-settings_8.0.2_all.deb
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'elementary-default-settings' instead of '../elementary-default-settings_8.0.2_all.deb'
The following packages will be DOWNGRADED:
  elementary-default-settings
0 upgraded, 0 newly installed, 1 downgraded, 0 to remove and 0 not upgraded.
Need to get 0 B/11.9 kB of archives.
After this operation, 4,096 B of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 /home/user/work/elementary-default-settings_8.0.2_all.deb elementary-default-settings all 8.0.2 [11.9 kB]
dpkg: warning: downgrading elementary-default-settings from 8.0.2+r431~ubuntu8.1 to 8.0.2
(Reading database ... 217242 files and directories currently installed.)
Preparing to unpack .../elementary-default-settings_8.0.2_all.deb ...
update-alternatives: using /usr/share/icons/Adwaita/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in auto mode
Unpacking elementary-default-settings (8.0.2) over (8.0.2+r431~ubuntu8.1) ...
Setting up elementary-default-settings (8.0.2) ...
update-alternatives: using /usr/share/icons/elementary/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in manual mode
Processing triggers for desktop-file-utils (0.27-2build1) ...
Processing triggers for gnome-menus (3.36.0-1.1ubuntu3) ...
Processing triggers for libglib2.0-0t64:amd64 (2.80.0-6ubuntu3.2) ...
N: Download is performed unsandboxed as root as file '/home/user/work/elementary-default-settings_8.0.2_all.deb' couldn't be accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)
user@test-vm:~/work/default-settings$ cat /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
user@test-vm:~/work/default-settings$ ls -l /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
-rw-r--r-- 1 root root 0 Jan  5 08:26 /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
user@test-vm:~/work/default-settings$ cat /etc/netplan/01-network-manager-all.yml
# Let NetworkManager manage all devices on this system
network:
  version: 2
  renderer: NetworkManager
user@test-vm:~/work/default-settings$ ls -l /etc/netplan/01-network-manager-all.yml
-rw-r--r-- 1 root root 104 Nov 22 01:58 /etc/netplan/01-network-manager-all.yml
user@test-vm:~/work/default-settings$ 

Never Manually Created 10-globally-managed-devices.conf

user@test-vm:~/work/default-settings$ cat /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
cat: /etc/NetworkManager/conf.d/10-globally-managed-devices.conf: No such file or directory
user@test-vm:~/work/default-settings$ ls -l /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
ls: cannot access '/etc/NetworkManager/conf.d/10-globally-managed-devices.conf': No such file or directory
user@test-vm:~/work/default-settings$ cat /etc/netplan/01-network-manager-all.yml
# Let NetworkManager manage all devices on this system
network:
  version: 2
  renderer: NetworkManager
user@test-vm:~/work/default-settings$ ls -l /etc/netplan/01-network-manager-all.yml
-rw-r--r-- 1 root root 104 Nov 22 01:58 /etc/netplan/01-network-manager-all.yml
user@test-vm:~/work/default-settings$ sudo apt install ../elementary-default-settings_8.0.2_all.deb
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 'elementary-default-settings' instead of '../elementary-default-settings_8.0.2_all.deb'
The following packages will be DOWNGRADED:
  elementary-default-settings
0 upgraded, 0 newly installed, 1 downgraded, 0 to remove and 0 not upgraded.
Need to get 0 B/11.9 kB of archives.
After this operation, 4,096 B of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 /home/user/work/elementary-default-settings_8.0.2_all.deb elementary-default-settings all 8.0.2 [11.9 kB]
dpkg: warning: downgrading elementary-default-settings from 8.0.2+r431~ubuntu8.1 to 8.0.2
(Reading database ... 217241 files and directories currently installed.)
Preparing to unpack .../elementary-default-settings_8.0.2_all.deb ...
update-alternatives: using /usr/share/icons/Adwaita/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in auto mode
Unpacking elementary-default-settings (8.0.2) over (8.0.2+r431~ubuntu8.1) ...
Setting up elementary-default-settings (8.0.2) ...
update-alternatives: using /usr/share/icons/elementary/cursor.theme to provide /usr/share/icons/default/index.theme (x-cursor-theme) in manual mode
Processing triggers for desktop-file-utils (0.27-2build1) ...
Processing triggers for gnome-menus (3.36.0-1.1ubuntu3) ...
Processing triggers for libglib2.0-0t64:amd64 (2.80.0-6ubuntu3.2) ...
N: Download is performed unsandboxed as root as file '/home/user/work/elementary-default-settings_8.0.2_all.deb' couldn't be accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)
user@test-vm:~/work/default-settings$ cat /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
user@test-vm:~/work/default-settings$ ls -l /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
-rw-r--r-- 1 root root 0 Oct 22 17:40 /etc/NetworkManager/conf.d/10-globally-managed-devices.conf
user@test-vm:~/work/default-settings$ cat /etc/netplan/01-network-manager-all.yml
# Let NetworkManager manage all devices on this system
network:
  version: 2
  renderer: NetworkManager
user@test-vm:~/work/default-settings$ ls -l /etc/netplan/01-network-manager-all.yml
-rw-r--r-- 1 root root 104 Nov 22 01:58 /etc/netplan/01-network-manager-all.yml
user@test-vm:~/work/default-settings$