Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppCenter sometimes opens to the Updates view #529

Closed
cassidyjames opened this issue Nov 7, 2017 · 2 comments
Closed

AppCenter sometimes opens to the Updates view #529

cassidyjames opened this issue Nov 7, 2017 · 2 comments
Labels
Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Nov 7, 2017

When opening AppCenter by clicking its icon in the dock, it's now opening to the Updates view instead of the Home view.

If I manually kill AppCenter, it doesn't continue doing this. I will try to figure out what causes it, but I'm seeing it in AppCenter on elementary OS and in Pop!_Shop on Pop!_OS.

@cassidyjames cassidyjames changed the title AppCenter opens to the Updates view AppCenter sometimes opens to the Updates view Nov 7, 2017
@cassidyjames
Copy link
Contributor Author

It seems like you can reproduce it like this:

  1. Log into your OS,
  2. Click an update notification, opening the app
  3. Close the app

Now all subsequent openings of AppCenter open to the updates view, even after running the updates. Killing AppCenter and re-launching seems to temporarily fix it so it opens to the home view again.

@cassidyjames cassidyjames added Status: Confirmed Verified by someone other than the reporter Priority: Medium Should be addressed when time allows labels Dec 21, 2017
edwood-grant pushed a commit to edwood-grant/appcenter that referenced this issue Dec 22, 2024
This also fix an issue where installed apps would not show up if your did not open the AppListUpdateView until the update worker ended.
leonardo-lemos pushed a commit that referenced this issue Dec 27, 2024
* Set vexpand property to false to avoid extra unnecesary space in listbox.

* Disable refresh_menuitem when clicking it an renabling it when job is complete

This is done to avoid multiple update check commands that could create duplicated update element in the list.

* Remove updated and installed list along with labels when checking for updates.

This commit also toggles the updates message properly when trying to check new updates. Even when the app closes. This removes all installed and updated apps so iit clears the view whn tyring to update again.

* Removing the placeholder methods.

Sionce this only appear when lists are empty, there not need to explicitly remove  since we arealready removing list data.

* Fixed a release notes icon bug when installing/cancelling and update

The release notes icon would appear when canelling an update of an application that doew nost have a description (and thus the icon should not appear)

* Fix for #529 Appcenter sometimes opens the updates view.

This also fix an issue where installed apps would not show up if your did not open the AppListUpdateView until the update worker ended.

* Use the refrsh action directlt action to update the refresh_menuitem button instead of action_name.

This helps to use the shortuct  to update elements and makes the sentiive property of the button more consistent when it starts and ends.

* Move the clearing of the update_liststore to a better place.

Apartfor being a better palce organizational asking. Thsi also avoids a bug when if you the application while listing updates, it will show a bad update list badge and also would keep the incomplete update list when re-opening the app.

* Restore the placeholder setup.

This is needed for when there are no updates. oops.

* Check the vexpand value of list_box after adding the possible items in installed_liststore

---------

Co-authored-by: italo-capasso <[email protected]>
@edwood-grant
Copy link
Contributor

Should be fixed by #2237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Should be addressed when time allows Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Development

No branches or pull requests

2 participants