Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter GNOME apps #75

Open
cassidyjames opened this issue Aug 26, 2021 · 5 comments
Open

Filter GNOME apps #75

cassidyjames opened this issue Aug 26, 2021 · 5 comments

Comments

@cassidyjames
Copy link
Contributor

Web and Evince show up since they are available in the remote, but they are not really the same as other curated AppCenter apps.

@dar5hak
Copy link
Contributor

dar5hak commented Sep 7, 2021

I could give this a shot in a day or two.

BTW what is the rationale for showing first-party elementary apps (like Calculator) here? I get that they show up in the GTK AppCenter, but so do Web and Evince.

@cassidyjames
Copy link
Contributor Author

@dar5hak they're first-party apps shipped as Flatpak in AppCenter, so it makes sense to show them. In the future we could even ship new but not-preinstalled apps in AppCenter.

I would be open to showing the GNOME apps as well if we rebranded them as we do in the OS itself, as these apps are not really the same as the upstream versions. To do so, we'd need to ship updated AppStream for them, which would fix them in the GTK client as well.

So I'm okay with either approach, but filtering them here seems like a quicker first step until we can sort it out on the AppStream side.

@dar5hak
Copy link
Contributor

dar5hak commented Sep 7, 2021

Makes sense. I see the possibility where some first-party app isn’t a candidate for being pre-installed, say, something targeted at developers.

@dar5hak
Copy link
Contributor

dar5hak commented Sep 23, 2021

I haven't been able to work on this, but for anyone who wants to try, these resources will be helpful:

@dar5hak
Copy link
Contributor

dar5hak commented Oct 5, 2021

No luck with the custom filter.

I tried with contains but apparently Liquid doesn't have a straightforward not operator, so you can do this:

flatpak_apps | where_exp:"app","app.id contains 'org.gnome'"

but not this:

flatpak_apps | where_exp:"app","not app.id contains 'org.gnome'"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants