Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require release information #20

Open
cassidyjames opened this issue Nov 29, 2018 · 4 comments
Open

Require release information #20

cassidyjames opened this issue Nov 29, 2018 · 4 comments

Comments

@cassidyjames
Copy link
Contributor

I thought this existed, but I've come across a couple of updates in the reviewer dashboard that lacked AppStream release information for the release being published. We should fail and file an issue that release notes are always required for the latest release


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@danirabbit danirabbit transferred this issue from elementary/houston May 11, 2021
@cassidyjames
Copy link
Contributor Author

To clarify, we should ensure the submitted tag has a matching AppStream release version with something in the description, and fail if there's no matching release. We still need to human-review that release description if it does exist, but could avoid a lot of busy work/back and forth with developers if we fail early if it doesn't even exist.

@danirabbit danirabbit transferred this issue from elementary/appcenter-dashboard May 16, 2021
@danirabbit
Copy link
Member

It looks like Flatpak will fail to build now without release info, so I think this can be considered as closed

@cassidyjames
Copy link
Contributor Author

cassidyjames commented Aug 12, 2021

@danrabbit maybe I could have worded this better; does it fail if the release being submitted doesn't have info? Like it might have historical releases but we should automatically require info for the version we're building.

@danirabbit
Copy link
Member

Oh that's an interesting point. I'd imagine it can't differentiate. So it's probably worth reopening this

@danirabbit danirabbit reopened this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants