Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captioned images can't contain mentions or rich-text #4124

Open
frebib opened this issue Jan 8, 2025 · 0 comments
Open

Captioned images can't contain mentions or rich-text #4124

frebib opened this issue Jan 8, 2025 · 0 comments
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@frebib
Copy link
Contributor

frebib commented Jan 8, 2025

Your use case

What would you like to do?

Have the full composer functionality when sending an image caption, for parity with sending a regular text message. This includes both the rich-text editor view as well as user/room mentions.

Amusingly, since matrix-org/matrix-rust-sdk@8205da8 and some very minor code edits in EXA, this can already be done when editing a caption; just not when sending it to begin with.

Why would you like to do it?

Mainly for functionality parity, but also because it's a pretty common thing to want to do

How would you like to achieve it?

Add a button to the AttachmentPreviewView to enable the rich-text composer and also implement the mention insert view too. There's a huge amount of crossover with the composer in the regular timeline screen, so ideally much of that logic would be deduplicated and reused.

matrix-org/matrix-rust-sdk#4475 should be all that's required on the SDK side. Most of what is missing is UI functionality in EXA.

Have you considered any alternatives?

Sending two separate messages?

Additional context

No response

Are you willing to provide a PR?

Yes

@frebib frebib added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

1 participant