Skip to content

Commit 83a999c

Browse files
authored
BREAKING CHANGE:chore: update menu.popup() API
sync menu.popup signature to breaking change in Electron 2.0
2 parents ea70664 + d34627b commit 83a999c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test-smoke/electron/test/main.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ menu.insert(0, menuItem);
568568
console.log(menu.items);
569569

570570
const pos = screen.getCursorScreenPoint();
571-
menu.popup(null, {x: pos.x, y: pos.y});
571+
menu.popup({x: pos.x, y: pos.y});
572572

573573
// main.js
574574
const template = <Electron.MenuItemConstructorOptions[]> [

vendor/fetch-docs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const mkdirp = require('mkdirp').sync
77
const os = require('os')
88

99
const downloadPath = path.join(os.tmpdir(), 'electron-api-tmp')
10-
const ELECTRON_COMMIT = 'f469059e9059aa0bda756022deb53322688dac29'
10+
const ELECTRON_COMMIT = '35e90f742b8a2f1006157da2a9f394cd055aff74'
1111

1212
rm(downloadPath)
1313

0 commit comments

Comments
 (0)