Skip to content

Commit 6f768ec

Browse files
fix: Revert "fix: position is dead, long live before/after (#108)" (#109)
This reverts commit 4e830d7.
1 parent 4e830d7 commit 6f768ec

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

test-smoke/electron/test/main.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -739,19 +739,19 @@ Menu.setApplicationMenu(menu); // Must be called within app.on('ready', function
739739

740740
Menu.buildFromTemplate([
741741
{ label: "4", id: "4" },
742-
{ label: "5", id: "5", after: ["4"] },
743-
{ label: "1", id: "1", before: ["4"] },
744-
{ label: "2", id: "2", },
742+
{ label: "5", id: "5" },
743+
{ label: "1", id: "1", position: "before=4" },
744+
{ label: "2", id: "2" },
745745
{ label: "3", id: "3" },
746746
]);
747747

748748
Menu.buildFromTemplate([
749-
{ label: "a" },
750-
{ label: "1" },
751-
{ label: "b" },
752-
{ label: "2" },
753-
{ label: "c" },
754-
{ label: "3" },
749+
{ label: "a", position: "endof=letters" },
750+
{ label: "1", position: "endof=numbers" },
751+
{ label: "b", position: "endof=letters" },
752+
{ label: "2", position: "endof=numbers" },
753+
{ label: "c", position: "endof=letters" },
754+
{ label: "3", position: "endof=numbers" },
755755
]);
756756

757757
// net

vendor/fetch-docs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const mkdirp = require('mkdirp').sync
77
const os = require('os')
88

99
const downloadPath = path.join(os.tmpdir(), 'electron-api-tmp')
10-
const ELECTRON_COMMIT = '7a508ca587ecc1f66c51bbce14a5dae6b7147c3c'
10+
const ELECTRON_COMMIT = '7c7543cb39c5a65e3ec49dae1a09f48f963f27bf'
1111

1212
rm(downloadPath)
1313

0 commit comments

Comments
 (0)