From 24607c0464988f884554e53624a9cd902a0630bd Mon Sep 17 00:00:00 2001 From: "electron-roller[bot]" <84116207+electron-roller[bot]@users.noreply.github.com> Date: Thu, 16 Nov 2023 21:17:59 +0000 Subject: [PATCH 1/3] chore: bump electronjs/node in .circleci/config.yml to 2.1.0 --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 1c8d536..27670fa 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.1 orbs: cfa: continuousauth/npm@2.1.0 - node: electronjs/node@1.1.0 + node: electronjs/node@2.1.0 jobs: test: From 41b965263f67fbae91af2241650dea6cebbc24d9 Mon Sep 17 00:00:00 2001 From: George Xu Date: Tue, 21 Nov 2023 15:41:23 -0800 Subject: [PATCH 2/3] build: add rosetta install --- .circleci/config.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index 27670fa..ca48301 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -64,6 +64,14 @@ workflows: jobs: - test: name: test-<< matrix.executor >>-<< matrix.node-version >> + pre-steps: + - when: + condition: + and: + - equal: [ node/macos, << matrix.executor >> ] + - equal: [ '14.16', << matrix.node-version >> ] + steps: + - node/install-rosetta matrix: alias: test parameters: From 6152cd077629dd24c5878250a335bc463c0223ec Mon Sep 17 00:00:00 2001 From: George Xu Date: Tue, 21 Nov 2023 15:45:07 -0800 Subject: [PATCH 3/3] update node versions --- .circleci/config.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ca48301..5377e96 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -80,10 +80,11 @@ workflows: - node/macos - node/windows node-version: - - 20.2.0 - - 18.14.0 - - 16.19.0 - - 14.19.0 + - '20.9' + - '18.17' + - '16.20' + # Stay below 14.17.0 or nvm tries to download arm64 artifacts which don't exist + - '14.16'd - cfa/release: requires: - test