Skip to content

Fix Minimum Supported Version Logic for Electron Versions #137

Open
@Santhoshmani1

Description

@Santhoshmani1

Electron fiddle explicitly handles the minimum supported version of Electron.

https://github.com/electron/fiddle/blob/35eef39df55eb6ccbe505466cab453d73a8cf18f/src/main/versions.ts#L41-L51

export function getReleasedVersions(): Array<Version> {
  // Don't support anything older than 0.30 (Aug 2015).
  // The oldest version known to releases.json.org is 0.20,
  // Pre-0.24.0 versions were technically 'atom-shell' and cannot
  // be downloaded with @electron/get.
  // TODO(dsanders11): upstream this logic to @electron/fiddle-core
  return knownVersions.versions
    .filter((ver) => !ver.version.startsWith('0.2'))
    .map(({ version }) => ({ version }));
}

What we can do ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions