Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run from ASAR Support #100

Closed
dsanders11 opened this issue Feb 25, 2024 · 6 comments · Fixed by #138
Closed

Run from ASAR Support #100

dsanders11 opened this issue Feb 25, 2024 · 6 comments · Fixed by #138
Labels
good first issue Good for newcomers released ✨ enhancement New feature or request

Comments

@dsanders11
Copy link
Member

In support of electron/fiddle#1551.

Would be nice if we could use @electron/asar to run a fiddle from an ASAR so we can exercise more code branches within Electron.

I think roughly this is what would need to be done in this repo:

  • Extend FiddleFactory constructor to take a new option, e.g. packAsAsar
  • Update FiddleFactory to use @electron/asar to package the fiddle into an ASAR when that option is used
  • Update tests to cover this case
@dsanders11 dsanders11 added ✨ enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2024
@hachimetsu
Copy link

hello there !
I think i going in wrong direction can u guide me plz...

@Aryankadyan
Copy link

want to work on this.

@Alok-2005
Copy link

@dsanders11 can I be assigned to work on this issue?

@dsanders11
Copy link
Member Author

@Aryankadyan, @Alok-2005, please do not ask to work on or be assigned issues. We welcome PRs to close issues, but you don't need to ask to work on it (although it's a good idea to check for any open PRs related to it) and we do not assign issues to external contributors.

@Alok-2005
Copy link

Hi @dsanders11 , I have raised a PR. Could you please review it at your convenience? Thanks!

Copy link

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers released ✨ enhancement New feature or request
Projects
None yet
4 participants