-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run from ASAR Support #100
Comments
hello there ! |
want to work on this. |
@dsanders11 can I be assigned to work on this issue? |
@Aryankadyan, @Alok-2005, please do not ask to work on or be assigned issues. We welcome PRs to close issues, but you don't need to ask to work on it (although it's a good idea to check for any open PRs related to it) and we do not assign issues to external contributors. |
Hi @dsanders11 , I have raised a PR. Could you please review it at your convenience? Thanks! |
🎉 This issue has been resolved in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
In support of electron/fiddle#1551.
Would be nice if we could use
@electron/asar
to run a fiddle from an ASAR so we can exercise more code branches within Electron.I think roughly this is what would need to be done in this repo:
FiddleFactory
constructor to take a new option, e.g.packAsAsar
FiddleFactory
to use@electron/asar
to package the fiddle into an ASAR when that option is usedThe text was updated successfully, but these errors were encountered: