Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cation adds api-review/requested when PR is labeled with api-review/reviewed #155

Open
itsananderson opened this issue Nov 22, 2023 · 1 comment

Comments

@itsananderson
Copy link
Member

This PR illustrates the problem: electron/electron#40301

When an API WG member has reviewed a PR and added feedback, I think we're supposed to add the api-review/reviewed label and remove the api-review/requested label. However, when we do that it looks like Cation automatically adds back the api-review/requested label (which triggers API WG notifications about a new PR).

If I'm understanding our API WG labeling system correctly, Cation should only be adding the api-review/requested label if no other api-review label (including api-review/reviewed) has been applied.

@dsanders11
Copy link
Member

Is api-review/reviewed a new label that's been created recently? It's not one of the labels that cation knows about.

cation/src/constants.ts

Lines 37 to 41 in b5ea25a

export const REVIEW_LABELS = {
REQUESTED: 'api-review/requested 🗳',
APPROVED: 'api-review/approved ✅',
DECLINED: 'api-review/declined ❌',
};

cation doesn't let humans modify those labels on a PR, since that would sidestep things. If you want to add api-review/reviewed as an intermediate state between requested and approved/declined, the logic in this repo will need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants