Do not copy sample assets if custom assets are provided #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user wants to manage their own assets, we should not include our own. This just leads to bloat and to confusion.
|
Hi, |
|
We really need a up to date fork at this point... |
3 tasks
artisanbhu
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Actually, I think this PR is incomplete. I find reference to "SampleAppx..png" log assets in the manifest template file which may need to be parameterized as well. Adding assets with "MyAppAppx..png" may break the app.
But, anyone looking for a workaround, if you simply provide assets with the matching name ( "SampleAppx.*.png" ), it overwrites the default logo files, and the app displays the correct logo.
electron forge config,
{
name: '@electron-forge/maker-appx',
config: {
assets: './app-stores/appx',
}
}
app-stores/appx folder:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user wants to manage their own assets, we should not include our own. This just leads to bloat and to confusion.
Fixes #133