Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting my website on netlify makes requests from preview builds logged #346

Open
orangecoloured opened this issue Nov 24, 2022 · 6 comments
Labels

Comments

@orangecoloured
Copy link

orangecoloured commented Nov 24, 2022

🐞 Describe the bug

I have ackee and my website both hosted on netlify.

ACKEE_ALLOW_ORIGIN="https://rckt.cc"
ACKEE_AUTO_ORIGIN="false"

But I see requests logged from the preview builds.

📚 To Reproduce

Probably have the tracked app hosted on netlify and see this happening on deploy?

💡 Expected behavior

I expected that the whitelisted origins prevent loggin requests from other sources.

🖼️ Screenshots

image

⚙️ Environment

  • Installation: Netlify
  • Ackee version: 3.4.1
@orangecoloured
Copy link
Author

Another deploy, another logged vist

image

@electerious
Copy link
Owner

That's strange. Can you check if Ackee sends the correct CORS headers? Is the visit logged by a browser or by the deployment system? Scripts might ignore the CORS headers.

@orangecoloured
Copy link
Author

Looks like it's logged by the deployment system.
When I visit the deployed snapshot I get proper response

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://ackee.rckt.cc/api. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 204.

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://ackee.rckt.cc/api. (Reason: CORS request did not succeed). Status code: (null).

@orangecoloured
Copy link
Author

Btw, I have a check for window object for initialisation and tracking. So, weird if it's a request that's happening on the "backend" side.

@VincentBrule
Copy link

Hello, I have exactly the same issue, let me know if I can give more details to help for the investigation

@axelsegebrecht
Copy link

Same issue here. Give me a shout and I'll post what ever info is helping to debug this :) Thank you for an awesome analytics tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants