allow configuring the prefetch count #27
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major change, the current behavior is to ACK a message as soon as is received.
I am proposing instead to ACK the message once is processed. With the
prefetchparameter unset, this almost the same than the current behavior.. rabbitmq will report that the messages are not acked yet but it will keep delivering messages as before.But this allow us to configure the prefetch count which is very useful. Let's say we know our worker can't handle more than 5 operations at the time, with this change you can initialize the server as:
More info about prefetch here.
In addition to this I am using
rejectif the command fail, this is an ack the message but mark it as rejected and does not re-queues it. This is helpful when you are looking at rabbitmq metrics for example.