Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enrichments] event.success_count should use representative count/adjusted count for the span #112

Closed
lahsivjar opened this issue Oct 16, 2024 · 1 comment · Fixed by #113
Closed

[enrichments] event.success_count should use representative count/adjusted count for the span #112

lahsivjar opened this issue Oct 16, 2024 · 1 comment · Fixed by #113
Assignees
@lahsivjar
Labels
bug Something isn't working

Comments

@lahsivjar
Copy link
Contributor

Currently, event.success_count enrichment uses 0 or 1, based on event.outcome -- this logic is inherited from APM.

However, for aggregated metrics, we correctly use the span's representative count in APM (ref). This seems to be a bug in APM.
@lahsivjar lahsivjar added the bug Something isn't working label Oct 16, 2024
This was referenced Oct 22, 2024
Merged
Open
@lahsivjar
Copy link
Contributor Author

Created a separate issue for handling the ingest-pipeline fixes for APM: elastic/apm-data#388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahsivjar lahsivjar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[enrichments]Use representative count for success count attr lahsivjar/opentelemetry-lib
1 participant
@lahsivjar