-
Notifications
You must be signed in to change notification settings - Fork 471
[elastic_agent] Fix metrics dashboard to include Elastic Defend #14569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
88cd1cf
to
056f0b6
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
056f0b6
to
3e1d4b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the Elastic Agent metrics dashboard to include metrics from Elastic Defend (endpoint security) processes. The dashboard was previously only showing metrics from core Elastic Agent processes, but now includes CPU and memory metrics from both data streams.
- Added Elastic Defend endpoint security dataset to dashboard filters and visualizations
- Enhanced CPU calculation formulas to handle both time-based and percentage-based metrics
- Updated field definitions to include the new
total.pct
CPU metric field
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/elastic_agent/manifest.yml | Version bump to 2.3.1 for the bug fix |
packages/elastic_agent/kibana/dashboard/elastic_agent-f47f18cc-9c7d-4278-b2ea-a6dee816d395.json | Updated dashboard configuration to include endpoint security data and enhanced CPU calculations |
packages/elastic_agent/data_stream/endpoint_security_metrics/fields/fields.yml | Added total.pct CPU field definition and reorganized existing CPU fields |
packages/elastic_agent/changelog.yml | Added changelog entry for the dashboard fix |
- name: system.ticks | ||
type: long | ||
metric_type: counter | ||
- name: total.pct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new field total.pct
is being added in the middle of existing fields, but the system.ticks
field that was previously at this location is moved to line 61. This creates a breaking change in field ordering that could affect existing queries or mappings. Consider adding new fields at the end of the section to maintain backward compatibility.
Copilot uses AI. Check for mistakes.
3e1d4b0
to
4c57c1e
Compare
💚 Build Succeeded
History
cc @AndersonQ |
|
Proposed commit message
Checklist
changelog.yml
file.[ ] I have verified that Kibana version constraints are current according to guidelines.[ ] I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
I suggest using a cloud stack because you'll need to install Elastic Defend and it's not possible on a Elastic computer. Thus you'll need a VM and it's easier with a cloud stack than with
elastic-package
Related issues
For the reviewer
When editing the dashboards there was no way I could make elastic-package to export the dashboard without adding "typeMigrationVersion": "10.2.0" , what breaks the build on CI saying this version of kibana in unknown. So I manually edited it back to its original value
Screenshots