Skip to content

Commit 8f1d482

Browse files
committed
address pr comments
1 parent 5642973 commit 8f1d482

File tree

6 files changed

+18
-20
lines changed

6 files changed

+18
-20
lines changed

output/schema/schema.json

Lines changed: 11 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

output/typescript/types.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

specification/indices/_types/SampleConfigurationOutput.ts renamed to specification/indices/_types/SampleConfiguration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ import { DateTime, Duration } from '@_types/Time'
2626
*/
2727
export class SamplingConfiguration {
2828
/**
29-
* The fraction of documents to sample.
29+
* The fraction of documents to sample between 0 and 1.
3030
*/
3131
rate: double
3232
/**

specification/indices/get_all_sample_configuration/_types/IndexSamplingConfiguration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919

2020
import { IndexName } from '@_types/common'
21-
import { SamplingConfiguration } from '@indices/_types/SampleConfigurationOutput'
21+
import { SamplingConfiguration } from '@indices/_types/SampleConfiguration'
2222

2323
export class IndexSamplingConfiguration {
2424
index: IndexName

specification/indices/get_sample_configuration/IndicesGetSampleConfigurationResponse.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
*/
1919

2020
import { IndexName } from '@_types/common'
21-
import { SamplingConfiguration } from '@indices/_types/SampleConfigurationOutput'
21+
import { SamplingConfiguration } from '@indices/_types/SampleConfiguration'
2222

2323
export class Response {
2424
body: {

specification/indices/put_sample_configuration/IndicesPutSampleConfigurationRequest.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import { RequestBase } from '@_types/Base'
2121
import { ByteSize, IndexName } from '@_types/common'
2222
import { double, integer } from '@_types/Numeric'
2323
import { Duration } from '@_types/Time'
24+
import { Stringified } from '@spec_utils/Stringified'
2425

2526
/**
2627
* Create or update sampling configuration.
@@ -39,7 +40,7 @@ export interface Request extends RequestBase {
3940
]
4041
path_parts: {
4142
/**
42-
* The name of the index.
43+
* The name of the index or data stream.
4344
*/
4445
index: IndexName
4546
}
@@ -63,7 +64,7 @@ export interface Request extends RequestBase {
6364
* The fraction of documents to sample. Must be greater than 0 and less than or equal to 1.
6465
* Can be specified as a number or a string.
6566
*/
66-
rate: double | string
67+
rate: Stringified<double>
6768
/**
6869
* The maximum number of documents to sample. Must be greater than 0 and less than or equal to 10,000.
6970
* @server_default 100

0 commit comments

Comments
 (0)