-
Notifications
You must be signed in to change notification settings - Fork 613
[DOCS] Adds information about elastic-esql gem #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I made minor suggestions for clarity and style.
Thank you @marciw! I included all of your suggestions. I kept the capitalized name since that's the product name (it's the same in its own README). I also modified the text on the last line since I want to explicitly let users know they don't need to use the official Elasticsearch client with this tool: - The `elastic-esql` library works independently of the {{es}} client, so you can use it alongside any client — not just Ruby.
+ The `elastic-esql` library works independently of the {{es}} client, so you can use it alongside any client — not just `elasticsearch-ruby` . Let me know what you think, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me to be specific about the client! I noticed an extra space but otherwise LGTM.
Co-authored-by: Marci W <[email protected]>
No description provided.