Skip to content

Commit fb279fa

Browse files
committed
RevertBackToBuiltinSerializer should be public and renamed it to HandleNestTypesOnSourceJsonConverter fixes #2995
1 parent c7851d2 commit fb279fa

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

src/Serializers/Nest.JsonNetSerializer/ConnectionSettingsAwareSerializerBase.Serializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ internal ConnectionSettingsAwareSerializerBase(
3939
BuiltinSerializer = builtinSerializer;
4040
this.Converters = new List<JsonConverter>
4141
{
42-
new RevertBackToBuiltinSerializer(BuiltinSerializer),
42+
new HandleNestTypesOnSourceJsonConverter(BuiltinSerializer),
4343
new TimeSpanToStringConverter()
4444
};
4545
_serializer = CreateSerializer(SerializationFormatting.Indented);

src/Serializers/Nest.JsonNetSerializer/Converters/RevertBackToBuiltinSerializer.cs renamed to src/Serializers/Nest.JsonNetSerializer/Converters/HandleNestTypesOnSourceJsonConverter.cs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99

1010
namespace Nest.JsonNetSerializer.Converters
1111
{
12-
internal class RevertBackToBuiltinSerializer : JsonConverter
12+
public class HandleNestTypesOnSourceJsonConverter : JsonConverter
1313
{
1414
private readonly IElasticsearchSerializer _builtInSerializer;
1515
public override bool CanRead => true;
1616
public override bool CanWrite => true;
1717

18-
public RevertBackToBuiltinSerializer(IElasticsearchSerializer builtInSerializer)
18+
public HandleNestTypesOnSourceJsonConverter(IElasticsearchSerializer builtInSerializer)
1919
{
2020
_builtInSerializer = builtInSerializer;
2121
}
@@ -49,8 +49,5 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
4949
};
5050

5151
public override bool CanConvert(Type objectType) => NestTypesThatCanAppearInSource.Contains(objectType);
52-
53-
54-
5552
}
5653
}

0 commit comments

Comments
 (0)