update CatAllocationRecord (#4705)

This commit updates the fields available on CatAllocationRecord
to match what is returned from Elasticsearch.

Fixes #4699

(cherry picked from commit f3b329f)

Author: russcam

src/Nest/Cat/CatAllocation/CatAllocationRecord.cs

@@ -1,25 +1,70 @@
 using Newtonsoft.Json;
+// Licensed to Elasticsearch B.V under one or more agreements.
+// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
+// See the LICENSE file in the project root for more information
+
+using System;
 
 namespace Nest
 {
 	[JsonObject]
 	public class CatAllocationRecord : ICatRecord
 	{
-		[JsonProperty("diskAvail")]
+		/// <summary>
+		/// Amount of disk available
+		/// </summary>
+		[JsonProperty("disk.avail")]
 		public string DiskAvailable { get; set; }
 
-		[JsonProperty("diskRatio")]
+		/// <summary>
+		/// Amount of disk used by Elasticsearch indices
+		/// </summary>
+		[JsonProperty("disk.indices")]
+		public string DiskIndices { get; set; }
+
+		/// <summary>
+		/// The percentage of disk used
+		/// </summary>
+		[JsonProperty("disk.percent")]
+		public string DiskPercent { get; set; }
+
+		[Obsolete("Use DiskPercent, DiskTotal, DiskAvailable, DiskTotal and DiskIndices")]
+		[JsonIgnore]
 		public string DiskRatio { get; set; }
 
-		[JsonProperty("diskUsed")]
+		/// <summary>
+		/// Total capacity of all volumes
+		/// </summary>
+		[JsonProperty("disk.total")]
+		public string DiskTotal { get; set; }
+
+		/// <summary>
+		/// Amount of disk used (total, not just Elasticsearch)
+		/// </summary>
+		[JsonProperty("disk.used")]
 		public string DiskUsed { get; set; }
 
+		/// <summary>
+		/// The host of the node
+		/// </summary>
+		[JsonProperty("host")]
+		public string Host { get; set; }
+
+		/// <summary>
+		/// The IP address of the node
+		/// </summary>
 		[JsonProperty("ip")]
 		public string Ip { get; set; }
 
+		/// <summary>
+		/// The name of the node
+		/// </summary>
 		[JsonProperty("node")]
 		public string Node { get; set; }
 
+		/// <summary>
+		/// Number of shards on the node
+		/// </summary>
 		[JsonProperty("shards")]
 		public string Shards { get; set; }
 	}

src/Tests/Tests/Cat/CatAllocation/CatAllocationApiTests.cs

@@ -1,4 +1,9 @@
-using Elasticsearch.Net;
+// Licensed to Elasticsearch B.V under one or more agreements.
+// Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
+// See the LICENSE file in the project root for more information
+
+using System.Linq;
+using Elasticsearch.Net;
 using FluentAssertions;
 using Nest;
 using Tests.Core.ManagedElasticsearch.Clusters;
@@ -25,7 +30,22 @@ protected override LazyResponses ClientUsage() => Calls(
 			(client, r) => client.CatAllocationAsync(r)
 		);
 
-		protected override void ExpectResponse(ICatResponse<CatAllocationRecord> response) =>
-			response.Records.Should().NotBeEmpty().And.Contain(a => !string.IsNullOrEmpty(a.Node));
+		protected override void ExpectResponse(ICatResponse<CatAllocationRecord> response)
+		{
+			var records = response.Records;
+			records.Should().NotBeEmpty().And.Contain(a => !string.IsNullOrEmpty(a.Node));
+
+			foreach (var record in records.Where(r => !string.IsNullOrEmpty(r.Ip)))
+			{
+				record.Shards.Should().NotBeNullOrEmpty();
+				record.DiskIndices.Should().NotBeNullOrEmpty();
+				record.DiskUsed.Should().NotBeNullOrEmpty();
+				record.DiskAvailable.Should().NotBeNullOrEmpty();
+				record.DiskTotal.Should().NotBeNullOrEmpty();
+				record.DiskPercent.Should().NotBeNullOrEmpty();
+				record.Host.Should().NotBeNullOrEmpty();
+				record.Node.Should().NotBeNullOrEmpty();
+			}
+		}
 	}
 }