Skip to content

Commit 8df5839

Browse files
committed
Fix #2195 change Query on PhraseSuggestCollate to ITemplateQuery
1 parent b0028d4 commit 8df5839

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

src/Nest/Search/Suggesters/PhraseSuggester/PhraseSuggestCollate.cs

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,31 +9,28 @@ namespace Nest
99
public interface IPhraseSuggestCollate
1010
{
1111
[JsonProperty(PropertyName = "query")]
12-
IScript Query { get; set; }
12+
ITemplateQuery Query { get; set; }
1313

1414
[JsonProperty(PropertyName = "prune")]
1515
bool? Prune { get; set; }
1616
}
1717

1818
public class PhraseSuggestCollate : IPhraseSuggestCollate
1919
{
20-
public IScript Query { get; set; }
21-
20+
public ITemplateQuery Query { get; set; }
2221

2322
public bool? Prune { get; set; }
2423
}
2524

2625
public class PhraseSuggestCollateDescriptor<T> : DescriptorBase<PhraseSuggestCollateDescriptor<T>, IPhraseSuggestCollate>, IPhraseSuggestCollate
2726
where T : class
2827
{
29-
IScript IPhraseSuggestCollate.Query { get; set; }
28+
ITemplateQuery IPhraseSuggestCollate.Query { get; set; }
3029

3130
bool? IPhraseSuggestCollate.Prune { get; set; }
3231

33-
public PhraseSuggestCollateDescriptor<T> Query(string script) => Assign(a => a.Query = (InlineScript)script);
34-
35-
public PhraseSuggestCollateDescriptor<T> Query(Func<ScriptDescriptor, IScript> scriptSelector) =>
36-
Assign(a => a.Query = scriptSelector?.Invoke(new ScriptDescriptor()));
32+
public PhraseSuggestCollateDescriptor<T> Query(Func<TemplateQueryDescriptor<T>, ITemplateQuery> selector) =>
33+
Assign(a => a.Query = selector?.Invoke(new TemplateQueryDescriptor<T>()));
3734

3835
public PhraseSuggestCollateDescriptor<T> Prune(bool? prune = true) => Assign(a => a.Prune = prune);
3936
}

src/Tests/Search/Request/SuggestUsageTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,9 @@ public SuggestUsageTests(ReadOnlyCluster cluster, EndpointUsage usage) : base(cl
188188
{
189189
Collate = new PhraseSuggestCollate
190190
{
191-
Query = new InlineScript("{ \"match\": { \"{{field_name}}\": \"{{suggestion}}\" }}")
191+
Query = new TemplateQuery
192192
{
193+
Inline = "{ \"match\": { \"{{field_name}}\": \"{{suggestion}}\" }}",
193194
Params = new Dictionary<string, object>
194195
{
195196
{ "field_name", "title" }

src/Tests/Search/Suggesters/SuggestApiTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,9 @@ protected override LazyResponses ClientUsage() => Calls(
196196
{
197197
Collate = new PhraseSuggestCollate
198198
{
199-
Query = new InlineScript("{ \"match\": { \"{{field_name}}\": \"{{suggestion}}\" }}")
199+
Query = new TemplateQuery
200200
{
201+
Inline = "{ \"match\": { \"{{field_name}}\": \"{{suggestion}}\" }}",
201202
Params = new Dictionary<string, object>
202203
{
203204
{ "field_name", "title" }

0 commit comments

Comments
 (0)