TryGetServerErrorReason should be virtual

russcam · russcam · commit 84f6d8413a1a · 2019-10-01T16:01:38.000+10:00
This commit changes TryGetServerErrorReason back to being virtual, otherwise this would be a breaking change in 7.x
diff --git a/src/Elasticsearch.Net/Responses/ElasticsearchResponse.cs b/src/Elasticsearch.Net/Responses/ElasticsearchResponse.cs
@@ -60,7 +60,7 @@ public virtual bool TryGetServerError(out ServerError serverError)
 				return ServerError.TryCreate(stream, out serverError);
 		}
 
-		protected bool TryGetServerErrorReason(out string reason)
+		protected virtual bool TryGetServerErrorReason(out string reason)
 		{
 			reason = null;
 			if (!TryGetServerError(out var serverError)) return false;

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public virtual bool TryGetServerError(out ServerError serverError)`
`60`	`60`	`return ServerError.TryCreate(stream, out serverError);`
`61`	`61`	`}`
`62`	`62`
`63`		`- protected bool TryGetServerErrorReason(out string reason)`
	`63`	`+ protected virtual bool TryGetServerErrorReason(out string reason)`
`64`	`64`	`{`
`65`	`65`	`reason = null;`
`66`	`66`	`if (!TryGetServerError(out var serverError)) return false;`