Skip to content

Commit 34d8a7d

Browse files
committed
Remove superfluous exception handling
1 parent caa3af3 commit 34d8a7d

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

src/Elasticsearch.Net/Connection/HttpConnection-CoreFx.cs

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public virtual ElasticsearchResponse<TReturn> Request<TReturn>(RequestData reque
9090
}
9191
catch (HttpRequestException e)
9292
{
93-
HandleException(builder, e);
93+
builder.Exception = e;
9494
}
9595

9696
return builder.ToResponse();
@@ -111,25 +111,12 @@ public virtual async Task<ElasticsearchResponse<TReturn>> RequestAsync<TReturn>(
111111
}
112112
catch (HttpRequestException e)
113113
{
114-
HandleException(builder, e);
114+
builder.Exception = e;
115115
}
116116

117117
return await builder.ToResponseAsync().ConfigureAwait(false);
118118
}
119119

120-
private void HandleException<TReturn>(ResponseBuilder<TReturn> builder, HttpRequestException exception)
121-
where TReturn : class
122-
{
123-
builder.Exception = exception;
124-
var webException = exception.InnerException as WebException;
125-
var response = webException?.Response as HttpWebResponse;
126-
if (response != null)
127-
{
128-
builder.StatusCode = (int)response.StatusCode;
129-
builder.Stream = response.GetResponseStream();
130-
}
131-
}
132-
133120
private static HttpRequestMessage CreateHttpRequestMessage(RequestData requestData)
134121
{
135122
var method = ConvertHttpMethod(requestData.Method);

0 commit comments

Comments
 (0)