Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popperjs is excessively creating new instances for external tooltips #2309

Closed
nickofthyme opened this issue Jan 23, 2024 · 0 comments · Fixed by #2310
Closed

Popperjs is excessively creating new instances for external tooltips #2309

nickofthyme opened this issue Jan 23, 2024 · 0 comments · Fixed by #2310
Assignees
Labels
bug Something isn't working :tooltip Related to hover tooltip

Comments

@nickofthyme
Copy link
Collaborator

Describe the issue
When using a tooltip synced across multiple charts, the performance can quickly be diminished. The main culprit in that the createPopper method is called on every mouse move, due to the settings changes on each render.

To Reproduce
Steps to reproduce the behavior:

  1. Go to this story
  2. Place a log within this hook via chrome source lookup.
  3. Notice the log is called to update the popperSettings on every mouse change for each external chart.

Expected behaviour
popperSettings are not excessively updated unnecessarily.

Version (please complete the following information):

  • Elastic Charts: latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working :tooltip Related to hover tooltip
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant