Extended LogEventConverter.ConvertToEcs<>() (#460)

bsnsaxo · Mpdreamz · web-flow · commit 2df5d155f3c1 · 2025-02-26T13:47:47.000+01:00
Extended LogEventConverter.ConvertToEcs&lt;&gt;() with an optional
EcsDocumentCreationCache input parameter that gets passed into
EcsDocument.CreateNewWithDefaults&lt;&gt;()

This is to support overwrites of static data such as those in
EcsDocument.Service

Co-authored-by: Martijn Laarman &lt;Mpdreamz@gmail.com&gt;
diff --git a/src/Elastic.CommonSchema.Serilog/LogEventConverter.cs b/src/Elastic.CommonSchema.Serilog/LogEventConverter.cs
@@ -21,10 +21,10 @@ public static class LogEventConverter
 		/// <summary>
 		/// Converts a <see cref="LogEvent"/> to an <typeparamref name="TEcsDocument"/>
 		/// </summary>
-		public static TEcsDocument ConvertToEcs<TEcsDocument>(LogEvent logEvent, IEcsTextFormatterConfiguration<TEcsDocument> configuration)
+		public static TEcsDocument ConvertToEcs<TEcsDocument>(LogEvent logEvent, IEcsTextFormatterConfiguration<TEcsDocument> configuration, EcsDocumentCreationCache? initialCache = null)
 			where TEcsDocument : EcsDocument, new()
 		{
-			var ecsEvent = EcsDocument.CreateNewWithDefaults<TEcsDocument>(logEvent.Timestamp, logEvent.Exception, configuration);
+			var ecsEvent = EcsDocument.CreateNewWithDefaults<TEcsDocument>(logEvent.Timestamp, logEvent.Exception, configuration, initialCache);
 
 			if (logEvent.TryGetScalarString(SpecialKeys.MachineName, out var machineName))
 			{

Original file line number	Diff line number	Diff line change
`@@ -21,10 +21,10 @@ public static class LogEventConverter`
`21`	`21`	`/// <summary>`
`22`	`22`	`/// Converts a <see cref="LogEvent"/> to an <typeparamref name="TEcsDocument"/>`
`23`	`23`	`/// </summary>`
`24`		`- public static TEcsDocument ConvertToEcs<TEcsDocument>(LogEvent logEvent, IEcsTextFormatterConfiguration<TEcsDocument> configuration)`
	`24`	`+ public static TEcsDocument ConvertToEcs<TEcsDocument>(LogEvent logEvent, IEcsTextFormatterConfiguration<TEcsDocument> configuration, EcsDocumentCreationCache? initialCache = null)`
`25`	`25`	`where TEcsDocument : EcsDocument, new()`
`26`	`26`	`{`
`27`		`- var ecsEvent = EcsDocument.CreateNewWithDefaults<TEcsDocument>(logEvent.Timestamp, logEvent.Exception, configuration);`
	`27`	`+ var ecsEvent = EcsDocument.CreateNewWithDefaults<TEcsDocument>(logEvent.Timestamp, logEvent.Exception, configuration, initialCache);`
`28`	`28`
`29`	`29`	`if (logEvent.TryGetScalarString(SpecialKeys.MachineName, out var machineName))`
`30`	`30`	`{`