Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBS automatic migration #15500

Closed
Tracked by #14931
raultorrecilla opened this issue Jan 31, 2025 · 1 comment
Closed
Tracked by #14931

TBS automatic migration #15500

raultorrecilla opened this issue Jan 31, 2025 · 1 comment
Assignees

Comments

@raultorrecilla
Copy link

raultorrecilla commented Jan 31, 2025

Context

Tail Based Sampling (TBS) has been a GA feature in APM Server since major version 8. During this time several SDHs were raised with bugs and issues related to TBS, ranging from high resource usage when TBS is enabled (CPU and memory) to high disk usage and other bugs. The current TBS implementation is backed by badger. We are using v2 which is quite outdated; but the newer version v4 introduces significant changes, especially in increased resource usage. See more details on upgrading badger in #11546.

Based on these issues, we decided to explore replacing badger with pebble, as described in #15246. Over the past weeks significant progress was made with this, and as shared in #15235 (comment), the switch to pebble brings huge performance improvements and decrease in disk space usage.

Hence, we decided to move forward with switching to pebble and the changes are merged into 9.0.

Problem to solve

Achieve an automatic migration from badger to pebble without data loss. Implement it in 8.18 so we have a path forward for customers migrating from 8.18 or upper to 9.0

Special considerations

There might be many special and edge cases, we need to be thorough in the testing phase.

@carsonip
Copy link
Member

carsonip commented Feb 5, 2025

Closing as we do not plan a migration.

#15235 is going to be a breaking change, and we'll provide public docs to help on-prem customers migrate to 9.0 in #15546. #15235 is not going to be in 8.x and as such there is no need for "automatic migration".

@carsonip carsonip closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants