-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase benchmark warmup time #15339
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @ericywl? 🙏
|
|
@rubvs From what I can gather, the benchmark warmup time is configured by |
@ericywl Correct. This should be the only change to make. You can move this out-of-draft and let's get feedback from the rest of the team. With this issue there isn't much "testing" you can do. I've already concluded this through running many benchmarks. However, this is a great first-issue:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for ESS, but probably not that helpful for standalone apm server (moxy) setup. Can we keep the 5m default for standalone apm setup?
We probably even should reduce it for standalone to not waste resources. |
Motivation/summary
Fixes #14948
Checklist
N / A
How to test these changes
Run throughput benchmark