Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tbs code not setting entry TTL #12449

Closed
kruskall opened this issue Jan 17, 2024 · 1 comment · Fixed by #12453
Closed

tbs code not setting entry TTL #12449

kruskall opened this issue Jan 17, 2024 · 1 comment · Fixed by #12453
Assignees
Labels
Milestone

Comments

@kruskall
Copy link
Member

APM Server version (apm-server version):

Description of the problem including expected versus actual behavior:

TBS code is setting the entry without the TTL:

This was spotted during the bugfix in #12120 (comment) but was kept as is. We should investigate whether this is a bug.

Steps to reproduce:

Please include a minimal but complete recreation of the problem,
including server configuration, agent(s) used, etc. The easier you make it
for us to reproduce it, the more likely that somebody will take the time to
look at it.

Provide logs (if relevant):

@carsonip
Copy link
Member

This only affects cases where badger.ErrTxnTooBig happens. Nevertheless this is concerning.

@simitt simitt added this to the 8.12 milestone Jan 18, 2024
@carsonip carsonip self-assigned this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants