TBS: log a warning with error field on processing trace failed (#15492) (#15494)

mergify[bot] · carsonip · web-flow · commit a3e72977f84c · 2025-01-31T00:04:27.000Z
(cherry picked from commit 00a250d) Co-authored-by: Carson Ip <carsonip@users.noreply.github.com>
diff --git a/x-pack/apm-server/sampling/processor.go b/x-pack/apm-server/sampling/processor.go
@@ -149,10 +149,10 @@ func (p *Processor) ProcessBatch(ctx context.Context, batch *modelpb.Batch) erro
 			stored = false
 			if p.config.DiscardOnWriteFailure {
 				report = false
-				p.rateLimitedLogger.Info("processing trace failed, discarding by default")
+				p.rateLimitedLogger.With(logp.Error(err)).Warn("processing trace failed, discarding by default")
 			} else {
 				report = true
-				p.rateLimitedLogger.Info("processing trace failed, indexing by default")
+				p.rateLimitedLogger.With(logp.Error(err)).Warn("processing trace failed, indexing by default")
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -149,10 +149,10 @@ func (p Processor) ProcessBatch(ctx context.Context, batch modelpb.Batch) erro`
`149`	`149`	`stored = false`
`150`	`150`	`if p.config.DiscardOnWriteFailure {`
`151`	`151`	`report = false`
`152`		`- p.rateLimitedLogger.Info("processing trace failed, discarding by default")`
	`152`	`+ p.rateLimitedLogger.With(logp.Error(err)).Warn("processing trace failed, discarding by default")`
`153`	`153`	`} else {`
`154`	`154`	`report = true`
`155`		`- p.rateLimitedLogger.Info("processing trace failed, indexing by default")`
	`155`	`+ p.rateLimitedLogger.With(logp.Error(err)).Warn("processing trace failed, indexing by default")`
`156`	`156`	`}`
`157`	`157`	`}`
`158`	`158`