-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span.id
field to transactions
#82
Comments
We have to cover the following types of documents / data flows:
For (1) it's mostly copying the value of This would allow to help fixing #40 |
I'd propose to ignore (2) for now. (2) could be solved by apm-agents / logging-libraries by always writing a |
Very good point for (2), this provides a good reason for doing this change across all APM agents. |
We want to converge span and transaction data models. For that, all transaction documents should also have a
span.id
field (where the field value is a copy oftransaction.id
).This also will allow better correlation between logs and arbitrary spans (that are either spans or transactions) for OTel use cases.
OTel log records know about the
span.id
they belong to. However, if they are not tied to spans as SpanEvents, there's no way to tell whether thespan.id
in a log record belongs to a span document or a transaction. So, in case of transaction the correlation breaks, because we query forspan.id = XYZ
while transactions do not have aspan.id
field at all.The text was updated successfully, but these errors were encountered: