Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using uint64 to store timestamps instead of timestamppb #129

Closed
lahsivjar opened this issue Jul 28, 2023 · 1 comment · May be fixed by #134
Closed

Consider using uint64 to store timestamps instead of timestamppb #129

lahsivjar opened this issue Jul 28, 2023 · 1 comment · May be fixed by #134
Assignees
@kruskall

Comments

@lahsivjar
Copy link
Contributor

If APMEvents is backed by vtproto's pool then timestamppb comes out as one of the most allocation heavy object. This was fixed in apm-aggregation by using uint64 to encode timestamps. If uint64 suits all our needs, we should consider promoting that package to apm-data: https://github.com/elastic/apm-aggregation/tree/main/aggregators/internal/timestamppb
@kruskall kruskall mentioned this issue Aug 1, 2023
Draft
@kruskall
Copy link
Member

kruskall commented Aug 9, 2023

Closed by #136

@kruskall kruskall closed this as completed Aug 9, 2023
@lahsivjar lahsivjar mentioned this issue Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kruskall kruskall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: migrate proto timestamp to uint64 kruskall/apm-data
2 participants
@lahsivjar @kruskall