From 59a06c05773537ab95c72d72802d3ea495352666 Mon Sep 17 00:00:00 2001 From: apmmachine Date: Fri, 5 Jan 2024 12:19:27 +0100 Subject: [PATCH] fix: split artifacts upload and use nodejs 14 for testing Signed-off-by: apmmachine --- .ci/scripts/test.sh | 5 +++++ .github/workflows/run-test/action.yml | 2 +- .github/workflows/test-reporter.yml | 8 ++++---- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.ci/scripts/test.sh b/.ci/scripts/test.sh index 3be2fc592..8ce8a97b9 100755 --- a/.ci/scripts/test.sh +++ b/.ci/scripts/test.sh @@ -6,6 +6,11 @@ APM_SERVER_PORT=${APM_SERVER_PORT:-"8200"} APM_SERVER_URL=${APM_SERVER_URL:-"http://apm-server:8200"} KIBANA_URL=${KIBANA_URL:-"http://kibana:5601"} +# The migration of this to Node.js 18 will wait. To update playwright (and browsers) +# to make it work in Node.js 18 and latest version in ubuntu (or another OS) +# will require us to invest a certain amount of time +NODEJS_VERSION=14 + # As long as there are issues with the ssl lets use 6.1.3 # see https://github.com/docker/docker-py/issues/3194 pip3 uninstall docker diff --git a/.github/workflows/run-test/action.yml b/.github/workflows/run-test/action.yml index 9b7ecf44e..ef3575c4c 100644 --- a/.github/workflows/run-test/action.yml +++ b/.github/workflows/run-test/action.yml @@ -66,6 +66,6 @@ runs: if: success() || failure() uses: actions/upload-artifact@v4 with: - name: test-results + name: test-results-${{ github.run_id }}-${{ github.run_attempt }} path: | packages/**/reports/TESTS-*.xml diff --git a/.github/workflows/test-reporter.yml b/.github/workflows/test-reporter.yml index a49255751..697f02f4b 100644 --- a/.github/workflows/test-reporter.yml +++ b/.github/workflows/test-reporter.yml @@ -15,7 +15,7 @@ jobs: steps: - uses: elastic/apm-pipeline-library/.github/actions/test-report@current with: - artifact: test-results # artifact name - name: JUnit Tests # Name of the check run which will be created - path: "**/*.xml" # Path to test results (inside artifact .zip) - reporter: java-junit # Format of test results + artifact: test-results-${{ github.run_id }}-${{ github.run_attempt }}-(.*) # artifact name + name: JUnit Tests # Name of the check run which will be created + path: "**/*.xml" # Path to test results (inside artifact .zip) + reporter: java-junit # Format of test results