Skip to content

Commit f8621e2

Browse files
committed
no scripts, https-pem is a pain here
1 parent 7d2ef05 commit f8621e2

File tree

1 file changed

+31
-20
lines changed

1 file changed

+31
-20
lines changed

Diff for: .github/workflows/test-fips.yml

+31-20
Original file line numberDiff line numberDiff line change
@@ -65,26 +65,37 @@ jobs:
6565
- run: cat /__w/_PipelineMapping/elastic/apm-agent-nodejs/PipelineFolder.json || true #XXX
6666
- run: |
6767
node -e 'const isFips = require("node:crypto").getFips(); console.log("isFips:", isFips); assert(isFips)'
68-
- run: npm ci
68+
# XXX https://github.com/elastic/apm-agent-nodejs/actions/runs/13001086210/job/36259730139?pr=4441
69+
# node_modules/https-pem
70+
- run: npm ci --ignore-scripts
6971
- run: node test/instrumentation/modules/express/basic.test.js
7072

71-
notify-on-failure:
72-
# XXX can we just run on "failure()"? Does that translate to "needs"? Guessing no.
73-
if: always()
74-
runs-on: ubuntu-24.04
75-
needs: test-fips
76-
steps:
77-
# - name: Notify in Slack
78-
# #XXX
79-
# if: ${{ failure() }}
80-
# uses: elastic/oblt-actions/slack/[email protected]
81-
# with:
82-
# bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
83-
# channel-id: "#apm-agent-node"
84-
# message: 'test-fips failed XXX'
85-
- id: check
86-
uses: elastic/oblt-actions/check-dependent-jobs@v1
73+
- name: Notify in Slack
74+
#XXX
75+
if: ${{ failure() }}
76+
uses: elastic/oblt-actions/slack/[email protected]
8777
with:
88-
jobs: ${{ toJSON(needs) }}
89-
- run: ${{ steps.check.outputs.is-success }}
90-
#XXX
78+
bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
79+
channel-id: "#apm-agent-node"
80+
message: 'test-fips failed XXX'
81+
82+
# notify-on-failure:
83+
# # XXX can we just run on "failure()"? Does that translate to "needs"? Guessing no.
84+
# if: always()
85+
# runs-on: ubuntu-24.04
86+
# needs: test-fips
87+
# steps:
88+
# # - name: Notify in Slack
89+
# # #XXX
90+
# # if: ${{ failure() }}
91+
# # uses: elastic/oblt-actions/slack/[email protected]
92+
# # with:
93+
# # bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
94+
# # channel-id: "#apm-agent-node"
95+
# # message: 'test-fips failed XXX'
96+
# - id: check
97+
# uses: elastic/oblt-actions/check-dependent-jobs@v1
98+
# with:
99+
# jobs: ${{ toJSON(needs) }}
100+
# - run: ${{ steps.check.outputs.is-success }}
101+
# #XXX

0 commit comments

Comments
 (0)