Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deps & use lockfile v2 (npm 7) & Migrate from deprecated request package #11

Open
emanuelb opened this issue May 15, 2021 · 2 comments

Comments

@emanuelb
Copy link

  1. Use newer lockfile format

    "lockfileVersion": 1,

    There is newer lockfileVersion 2 (different file format) which is available & generated by npm 7:
    https://github.blog/2021-02-02-npm-7-is-now-generally-available/#changes-to-the-lockfile

  2. Upgrade packages

    "cheerio": "^1.0.0-rc.2",

    latest version of cheerio is 1.0.0-rc.9
    "request": "^2.69.0"

    latest version of request is 2.88.2

  3. request package is deprecated and migration to another package is needed.

@eladnava
Copy link
Owner

Hi @emanuelb,
Thanks for your suggestion. Please submit a PR with the requested changes. 👍

@NightScript370
Copy link

I have just forked the repo and I will be replacing everything shortly.

To clarify; I will replace the request package with fetch, a built-in replacement who's API is already common-found in the JavaScript world. However, since Node.JS introduced it very late into the game, I will be adding a polyfill.
Cheerio's syntax is also non-standard; we now use the way JS interfaces with DOM, so that will be switched too.
Finally, lock file will be recreated, so it'll be upgraded regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants