Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find functionality missing (ctrl + f not working) #44

Closed
heiba opened this issue May 25, 2017 · 14 comments
Closed

Find functionality missing (ctrl + f not working) #44

heiba opened this issue May 25, 2017 · 14 comments

Comments

@heiba
Copy link

heiba commented May 25, 2017

Hello,

First of all, well done on creating Applicationize, within 2 days of getting my mac, it's now my most-used app.

However, one big missing feature is: ctrl+f , the find functionality doesn't work unfortunately.

You know how essential the find functionality is in many web apps, I don't really need to mention the million use cases when Applicationizing Wikipedia, Google Keep, Facebook, etc

Let me know if there's a work around please

Thanks

@heiba heiba changed the title Ability to search Find functionality missing (ctrl + f not working) May 25, 2017
@claytonolley
Copy link

claytonolley commented May 25, 2017 via email

@eladnava
Copy link
Owner

eladnava commented Jun 2, 2017

Thanks for your kind words!

The webview.find() method could be of assistance in implementing this:
https://developer.chrome.com/apps/tags/webview#method-find

However, we would also have to design the UI for the find popup and highlighting the results on the page.

It appears to be possible to implement this, but until this is ready, you can try the following:

  1. Go to the target website
  2. Click the three vertical dots in the top right of Chrome
  3. More Tools -> Add to Applications
  4. Tick Open as window

This type of app is a workaround for Applicationize and does support Ctrl + F.

@heiba
Copy link
Author

heiba commented Jun 2, 2017

Hello Elad,

Can you not use the existing chrome find function in Applicationize ?

The work around you provided doesn't apply on mac -> hence why I am using Applicationize

@eladnava
Copy link
Owner

eladnava commented Jun 2, 2017

Hi @heiba,
Sorry, I forgot to mention that you must enable the following Chrome flags (chrome://flags/):

  1. The new bookmark app system
  2. Allow hosted apps to be opened in windows
  3. Creation of app shims for hosted apps on Mac

Then, follow the steps I mentioned above.

@eladnava
Copy link
Owner

eladnava commented Jun 2, 2017

I have went ahead and implemented this into Applicationize! 🎉

The key combination CMD + F now brings up a simplified find box with very similar behavior to Chrome's native find functionality:

screen shot 2017-06-02 at 3 38 00 pm

@heiba
Copy link
Author

heiba commented Jun 2, 2017

Amazing work!! Tested it, and it works great! Please also make CMD + F hide the find box if already visible OR have an 'x' button that will hide the find box. Currently, there is no way to hide the find box.

Also, would be superb if the search could be triggered by typing characters in the box not by pressing enter, this would really make it same as the find box in Chrome!

@eladnava
Copy link
Owner

eladnava commented Jun 2, 2017

@heiba Press Escape to hide the find box. On Chrome, pressing CMD + F does not hide the open box.

Regarding find-as-you-type, done! 👍

@heiba
Copy link
Author

heiba commented Jun 2, 2017

You're superb @eladnava , find-as-you-type working like a charm!

@heiba
Copy link
Author

heiba commented Jun 2, 2017

Pressing Escape in Applicationize while in fullscreen will exit full screen, then I need to press escape again to hide find box.

In chrome, pressing escape while in full scree, will hide find box and will not exit full screen.

Could you possibly resolve this inconvenience please :)

@eladnava
Copy link
Owner

eladnava commented Jun 3, 2017

Hi @heiba,
I tried to reproduce this on YouTube in full screen mode but failed.

Which site with full screen mode are you experiencing this on?

@heiba
Copy link
Author

heiba commented Jun 5, 2017

Try messenger.com, keep.google.com, any website i tried with really

@eladnava
Copy link
Owner

eladnava commented Jun 5, 2017

Hi @heiba,
How do you enter full screen mode in those websites? There is no UI control for this.

@heiba
Copy link
Author

heiba commented Jun 5, 2017

hi @eladnava , I believe there is a misunderstanding. Any window in Mac can go to full screen if you click on the green button, which makes the window full screen and shifts it right in its own space screen in Mac.

This is Google Keep applicationized in normal mode

screen shot 2017-06-06 at 12 51 42 am

This is Google Keep applicationized in fullscreen mode

fullscreen1

This is Google Keep applicationized in normal mode and I hover to display the menu bar at the top

screen shot 2017-06-06 at 12 52 02 am

@eladnava
Copy link
Owner

eladnava commented Jun 6, 2017

Hi @heiba,
Thanks for the detailed explanation. I was able to reproduce your issue.

It appears that Chrome packaged apps in full screen mode cannot listen for the Escape key until the full screen mode is minimized.

So, I think a workaround would be to add a X icon in the find box. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants