Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional permissions to manifest file #22

Closed
mikekolganov opened this issue Aug 23, 2016 · 5 comments
Closed

Add optional permissions to manifest file #22

mikekolganov opened this issue Aug 23, 2016 · 5 comments

Comments

@mikekolganov
Copy link

Story: When Chrome asks user for permissions on regular tab (like notifications, access to camera and min) dialog is displayed at top of the page. But applicationized extensions isn't displayed these dialogs. And to enable notifications user needs to open applicationized website in regular tab to allow required permissions.

Suggestion: allow to choose permissions on generating applicationize under "Advanced" button. Not all, just common like audioCapture, videoCapture, notifications, etc. and put them to manifest file along with webview.

Related to #13.

@eladnava
Copy link
Owner

Great suggestion @mikekolganov, any chance you'd have time to submit a PR?

@eladnava
Copy link
Owner

Anyone up for this?

@ATXMJ
Copy link

ATXMJ commented Mar 24, 2017

This is desperately needed. There are so many sites that I would applicationize if they could display notifications.

In the meantime, the following doesn't work for me. Even if the website has full permissions and ability to display notifications via chrome tabs, the applicationized version of the website has no permissions, and fails to prompt for them.

And to enable notifications user needs to open applicationized website in regular tab to allow required permissions

@eladnava
Copy link
Owner

eladnava commented Mar 24, 2017

Either resolving #25 or submitting a PR to add optional permission support would resolve this issue. Anyone up for this? 👍

@eladnava
Copy link
Owner

eladnava commented May 22, 2017

This has now been implemented in 006839b and 6ee2160 !

The following permissions can now be granted in the Advanced Options section of https://applicationize.me/now:

  • audioCapture
  • videoCapture
  • notifications

If there are any other permissions you would like to be able to control, let me know! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants