-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotkeys for starting game #144
base: main
Are you sure you want to change the base?
Conversation
is this how you add a newline in JSX i have no idea lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the functionality a lot, and it works beautifully.
I'm personally not a fan of including the keyboard shortcut in the button label, it makes it visually very cluttered. I'd be in favor of removing it, and adding a paragraph on the 'Help' page (in the Layout and Controls section). Especially because the key combinations you have chosen (I don't know any better ones) might interact with browsers as well.
Also, would it be possible to have another hotkey for the 'Play again' button at the end of the game? That would be very helpful for someone to fully interact with the website by keyboard only.
saw that development on this repo is starting back up again, so i'll try to bring this PR up to date at some point when i'm back in boston in january (so removing the keyboard shortcut and adding a "play again" hotkey). |
Made the promised changes (although I'm not in boston yet: flying out today 😁 ). |
is this how you add a newline in JSX i have no idea lol
closes #136