Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enable launching Bottlerocket AMIs on AWS Neuron Instances #8111

Open
vigh-m opened this issue Jan 2, 2025 · 1 comment
Open
Labels
kind/feature New feature or request

Comments

@vigh-m
Copy link

vigh-m commented Jan 2, 2025

What feature/behavior/change do you want?

We would like eksctl to enable support for launching Managed and Unmanaged Nodes for AWS Neuron instance types (Inferentia and Trainium Instances) with Bottlerocket AMIs. This includes launching the neuron-device-plugin.

The standard Bottlerocket AMI variant (aws-k8s-1.xx) from v1.27.0 onwards has this support built in. The upcoming AMI will have greater support as described below.

For a Proof Of Concept and local testing, the following diff was used:

diff --git a/pkg/apis/eksctl.io/v1alpha5/validation.go b/pkg/apis/eksctl.io/v1alpha5/validation.go
index 1ac66eab9..b3bd93345 100644
--- a/pkg/apis/eksctl.io/v1alpha5/validation.go
+++ b/pkg/apis/eksctl.io/v1alpha5/validation.go
@@ -676,7 +676,7 @@ func validateNodeGroupBase(np NodePool, path string, controlPlaneOnOutposts bool
                }
        }

-       if ng.AMIFamily != NodeImageFamilyAmazonLinux2 && ng.AMIFamily != "" {
+       if ng.AMIFamily != NodeImageFamilyAmazonLinux2 && ng.AMIFamily != NodeImageFamilyBottlerocket && ng.AMIFamily != "" {
                // Only AL2 supports Inferentia hosts.
                if instanceutils.IsInferentiaInstanceType(instanceType) {
                        return ErrUnsupportedInstanceTypes("Inferentia", ng.AMIFamily, fmt.Sprintf("please use %s instead", NodeImageFamilyAmazonLinux2))

Why do you want this feature?

Bottlerocket OS is adding support for Neuron Instances. At this time, the OS already ships with the Neuron device drivers and can use the Neuron device. With the new setting change linked, containers should be able to take ownership of requested devices.

@vigh-m vigh-m added the kind/feature New feature or request label Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Hello vigh-m 👋 Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant