Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication in gradle tasks that clone repositories #1051

Open
wmdietl opened this issue Jan 6, 2025 · 0 comments
Open

Reduce duplication in gradle tasks that clone repositories #1051

wmdietl opened this issue Jan 6, 2025 · 0 comments
Assignees
@Ao-senXiong
Labels
build_system

Comments

@wmdietl
Copy link
Member

wmdietl commented Jan 6, 2025 •
edited
Loading

Regarding this comment:
In CI we are cloning something from the PR authors org/branch and then here we're trying to pull in the eisop version. I don't think that is correct.

We should do what we do in the createCloneTask in build.gradle: simply pull if the directory already exists.
Can you open a separate PR that reduces the duplication between the demos and template tasks by reusing the createCloneTask (or extracting some of its logic) and then using that here.

Originally posted by @wmdietl in #1048 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ao-senXiong Ao-senXiong

Labels
build_system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use createCloneTask for templateTest and demoTest Ao-senXiong/checker-framework
2 participants
@wmdietl @Ao-senXiong