Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail for dependency review #1047

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't fail for dependency review #1047

wants to merge 2 commits into from

Conversation

Ao-senXiong
Copy link
Member

@Ao-senXiong Ao-senXiong commented Jan 5, 2025 •
edited
Loading

Fixes #1045

@Ao-senXiong Ao-senXiong changed the title Use longer timeout parameter for dependency review Don't fail for dependency review Jan 5, 2025
@Ao-senXiong Ao-senXiong requested a review from wmdietl January 5, 2025 06:07
wmdietl
wmdietl reviewed Jan 5, 2025
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a vulnerable dependency so we can see what happens?
If the task is green even when there is a vulnerable dependency, we will miss it if the job is always green.

@wmdietl wmdietl assigned Ao-senXiong and unassigned wmdietl Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl left review comments

Assignees

@Ao-senXiong Ao-senXiong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency review in PRs
2 participants
@Ao-senXiong @wmdietl