Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Java 8 and support module #1036

Open
Ao-senXiong opened this issue Dec 30, 2024 · 0 comments
Open

Deprecate Java 8 and support module #1036

Ao-senXiong opened this issue Dec 30, 2024 · 0 comments

Comments

@Ao-senXiong
Copy link
Member

Places we need to look for Annotatedfor to support module:

Suppress warnings:

public boolean shouldSuppressWarnings(@Nullable TreePath path, String errKey) {

Applying defaulting:

There comment seems wrong for applying default as getEnclosingElement() will return module if module-info exisit. See If this is a package, its module is returned if such a module exists. Otherwise, null is returned

However, we still need to decide the TODO should AnnotatedFor apply to subpackages??. Looks like the logic should be more consistent if we want to handle module correctly.

          We should also start thinking about proper handling for modules. We should similarly look whether there is an annotation on an enclosing module. To do this, it would be easiest to assume we run on Java 9+. So maybe it is time to drop Java 8 support and have Java 11 as minimum requirement. Can you open an issue in which we collect all the places where modules would need to be handled?

Originally posted by @wmdietl in #1034 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant