Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple languages #16

Open
eikowagenknecht opened this issue Mar 16, 2022 · 5 comments
Open

Support multiple languages #16

eikowagenknecht opened this issue Mar 16, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@eikowagenknecht
Copy link
Owner

Most platforms display the offerings in the language the browser sends. Currently it is hardcoded to "en-US", but it would be nice to (additionally) add more languages. The question is how those languages should be handled. Add all translations in the RSS feeds for the entry? Create seperate feeds for every language?

@louanfontenele
Copy link

louanfontenele commented Aug 19, 2022

It would be great if the bot also had an option for multi-languages.

I can translate to Brazilian Portuguese if you want.

@louanfontenele
Copy link

@eikowagenknecht any news about multiple languages? :D

@eikowagenknecht
Copy link
Owner Author

@louanfontenele I think this will take quite a while, so unfortunately no, neither news nor an estimated date ;-)

@eikowagenknecht eikowagenknecht self-assigned this Oct 22, 2023
@azurejoga
Copy link

Hi, any results from this? I would love to help with implementation for new languages

@eikowagenknecht
Copy link
Owner Author

Hey! Some exciting news first:

I'm currently rewriting LootScraper in Node.js/TypeScript. This transition from Python comes after gaining more experience with the Node.js ecosystem and encountering some performance and stability challenges with the current version.
The rewrite is nearly feature-complete and has amazing , and I expect to finish within the next few weeks. After that, I'm planning to implement new features, with internationalization being a priority.

Proposed i18n Approach:
The simplest implementation would be a global language setting in the config file, meaning:

  • All users would share the same language setting
  • Only static text would need translation
  • Scraping would run in the configured language

Feedback Needed
I'd appreciate your input on:

  • Would a single global language setting meet your needs?
  • Are you planning to use this for self-hosted instances or the public Telegram bot/RSS feeds?

Note: Supporting multiple languages for the public services would significantly increase complexity, particularly around the scraping process, because multiple languages would need to be scraped, stored etc.

eikowagenknecht pushed a commit that referenced this issue Jan 7, 2025
…th 4 updates (#16)

Bumps the npm-minor-and-patch group with 4 updates in the / directory: [grammy](https://github.com/grammyjs/grammY), [yaml](https://github.com/eemeli/yaml), [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint).


Updates `grammy` from 1.33.0 to 1.34.0
- [Release notes](https://github.com/grammyjs/grammY/releases)
- [Commits](grammyjs/grammY@v1.33.0...v1.34.0)

Updates `yaml` from 2.6.1 to 2.7.0
- [Release notes](https://github.com/eemeli/yaml/releases)
- [Commits](eemeli/yaml@v2.6.1...v2.7.0)

Updates `@types/node` from 22.10.2 to 22.10.3
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Updates `typescript-eslint` from 8.18.2 to 8.19.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.19.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: grammy
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: npm-minor-and-patch
- dependency-name: yaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: npm-minor-and-patch
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm-minor-and-patch
- dependency-name: typescript-eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: npm-minor-and-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants