Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Egglog viz cut off without indication #460

Open
oflatt opened this issue Nov 5, 2024 · 4 comments
Open

Egglog viz cut off without indication #460

oflatt opened this issue Nov 5, 2024 · 4 comments

Comments

@oflatt
Copy link
Member

oflatt commented Nov 5, 2024

The egglog visualization in the demo fails to show the whole egraph, and doesn't give you any indication that it dropped some nodes. Child nodes that were dropped are shown as ellipsis which is good but it still doesn't let you know that it's not the entire egraph.

As a side-node, I would love an input that lets you configure the node cutoff

@saulshanabrook
Copy link
Member

What if we just removed the node cutoff for the egglog visualizer on the website? i.e. show all nodes.

Hopefully the new visualizer can work with some of the larger graphs, and if it stumbles, I would be down to try to add the functionality there to make it manageable instead of at serialization time.

Do you have an example you encountered this on so we could try what it looks like unfiltered?

@oflatt
Copy link
Member Author

oflatt commented Nov 8, 2024

I think d3 falls over easily after a few thousand nodes, so we should still have a cutoff.
Eggcc runs produce enormous egraphs, here's the ackerman.egg benchmark file
test.txt

@saulshanabrook
Copy link
Member

Thanks for the example... I might have a go at at least exploring how feasible it would be to load all of this at once in the new visualizer, even if not all of it rendered at once.... Like some way to allow iterative exploration that starts with it in some collapsed form and lets you click around to expand things?

@oflatt
Copy link
Member Author

oflatt commented Nov 11, 2024

I'd love that, it's exactly what I had in mind for your visualizer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants